search

pravega / pravega-client-rust

Rust based Pravega client.
Apache License 2.0
31 stars 25 forks source link

Python Bindings instructions are outdated #450

Closed gfinol closed 10 months ago

gfinol commented 1 year ago

Problem description Instructions to generate Python Bindings are not updated to the last version of maturin. Since version 0.13, flag --no-sdist was removed in maturin. Therefore, when following the Steps to generate python bindings for Pravega instructions, the build fails in step 2.

Problem location In the instructions: Steps to generate python bindings for Pravega

Suggestions for an improvement Update the instructions according to the maturin migration guide.

gfinol commented 1 year ago

I've seen that in python/pyproject.toml there is an explicit requirement: "maturin>=0.14,<0.15".

Therefore, it would be to also interesting to update the installation step for maturin in the instructions to respect this requirement.

Something like pip install maturin==0.14