search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 534: Provide support to configure segment store port #535

Closed anishakj closed 3 years ago

anishakj commented 3 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

Provided support to configure segment store ports. If the port is not mentioned in pravega options,default port will be set as 12345

Purpose of the change

Fixes #534

What the code does

Added support to configure segment store port.

How to verify it

Verified that segment store pods are coming up with different port number, if it is configured. If port number is not specified, segment store pod is coming up with default port number Verified changing segment store port at run time after Pravega is installed. Verified changing segment store port at run time after Pravega is installed with external access.

codecov-commenter commented 3 years ago

Codecov Report

Merging #535 (d5320c6) into master (f3c81fb) will decrease coverage by 0.12%. The diff coverage is 35.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   70.55%   70.43%   -0.13%     
==========================================
  Files          15       15              
  Lines        3573     3616      +43     
==========================================
+ Hits         2521     2547      +26     
- Misses        932      942      +10     
- Partials      120      127       +7
Impacted Files Coverage Δ
...roller/pravegacluster/pravegacluster_controller.go 51.88% <16.66%> (+0.24%) :arrow_up:
pkg/controller/pravega/pravega_segmentstore.go 91.72% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3c81fb...d5320c6. Read the comment docs.