search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 537: Making JVM Options configurable #546

Closed SrishT closed 3 years ago

SrishT commented 3 years ago

Signed-off-by: SrishT Srishti.Thakkar@dell.com

Change log description

Removes the hardcoded JVM options from the operator code, so that users can easily set their desired configuration through the charts, and also modify them if required.

Purpose of the change

Fixes #537, #460

What the code does

Removes the hardcoded JVM options from the operator code.

How to verify it

The segmentstore and controller should be configured with the JVM options that are provided within the values.yaml by the user. Also these values can be easily modified even after the pravega cluster has been deployed by editing the pravega cluster spec.

codecov-commenter commented 3 years ago

Codecov Report

Merging #546 (b001feb) into master (a2d2b32) will decrease coverage by 1.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   71.97%   70.88%   -1.10%     
==========================================
  Files          15       15              
  Lines        3665     3617      -48     
==========================================
- Hits         2638     2564      -74     
- Misses        911      934      +23     
- Partials      116      119       +3
Impacted Files Coverage Δ
pkg/controller/pravega/pravega_controller.go 93.72% <100.00%> (+3.60%) :arrow_up:
pkg/controller/pravega/pravega_segmentstore.go 90.72% <100.00%> (-9.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2d2b32...b001feb. Read the comment docs.