pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 280: Read InfluxDB credentials from a secret #563

Closed anishakj closed 3 years ago

anishakj commented 3 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

Added a new field InfluxDBSecret in Pravega spec, so that users can mention the secret names rather than passing username/password as plain text.

Purpose of the change

Fixes #280

What the code does

It will read the secret from the user, and if it is mentioned secret is mounted in controller and segment store pods at /etc/influxdb-secret-volume/

How to verify it

Verified that secret is mounted at controller and segment store pods.

codecov-commenter commented 3 years ago

Codecov Report

Merging #563 (36f6608) into master (8d45948) will increase coverage by 1.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
+ Coverage   73.29%   74.56%   +1.26%     
==========================================
  Files          15       15              
  Lines        4093     4144      +51     
==========================================
+ Hits         3000     3090      +90     
+ Misses        967      932      -35     
+ Partials      126      122       -4     
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go 98.34% <100.00%> (+0.14%) :arrow_up:
pkg/apis/pravega/v1beta1/zz_generated.deepcopy.go 99.43% <100.00%> (+0.60%) :arrow_up:
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (+8.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d45948...36f6608. Read the comment docs.