pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 564: Removing supported versions configmap #565

Closed SrishT closed 3 years ago

SrishT commented 3 years ago

Signed-off-by: SrishT Srishti.Thakkar@dell.com

Change log description

Removes the supported versions configmap from the pravege operator.

Purpose of the change

Fixes #564

What the code does

Removes the version validation from the validating webhook at the time of installation or upgrades of the pravega cluster. However the webhook will continue to check the format of the image being provided and will not allow any downgrade, unless while trying to rollback the cluster in case of a failed upgrade.

How to verify it

The pravega operator should allow installation of any pravega version given in the correct format (i.e. MAJOR.MINOR.PATCH-XXXX), and should also allow upgrades to any other pravega version. Downgrades are however not allowed.

The following scenarios have been tested

codecov-commenter commented 3 years ago

Codecov Report

Merging #565 (f2accc4) into master (087b0fb) will increase coverage by 0.03%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   73.25%   73.29%   +0.03%     
==========================================
  Files          15       15              
  Lines        4121     4093      -28     
==========================================
- Hits         3019     3000      -19     
+ Misses        972      967       -5     
+ Partials      130      126       -4     
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravegacluster_types.go 26.73% <66.66%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 087b0fb...f2accc4. Read the comment docs.