pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Add customized config to skip finalizers. #582

Closed realAaronWu closed 2 years ago

realAaronWu commented 2 years ago

Description

Pravega cluster has mandatory finalizers in order to clean up znodes before deleting the pods. This should be fine if we always delete pravegacluster pods before deleting the operators. This can be done by injecting a helm pre-delete hook. But on VS7 env, they forbid calling helm hooks, and VS terminates the namespace which kills all pods/secrets/configmaps at once without ordering, so deadlock can happen if operators are killed first before the pravegacluster pods. Add this config flag to skip adding finalizers to pravegacluster to avoid this situation.

Importance

should-have

Location

reconcileFinalizers logic

Suggestions for an improvement

Add disableFinalizer config

anishakj commented 2 years ago

Fixed by PR https://github.com/pravega/pravega-operator/pull/583