search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

[Issue 582] add disable finalizer config #583

Closed realAaronWu closed 2 years ago

realAaronWu commented 2 years ago

Change log description

add DisableFinalizer config and skip adding zkFinalziers when set it to true.

Purpose of the change

Issue-582

What the code does

skip adding zkFinalziers when DisableFinalizer set to true.

How to verify it

Set disableFinalizer to true in values and deploy Pravega operator, the deployed pravega clusters should have the finalizers as empty.

codecov-commenter commented 2 years ago

Codecov Report

Merging #583 (4354502) into master (d7e242f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #583   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files          16       16           
  Lines        4229     4229           
=======================================
  Hits         3137     3137           
  Misses        962      962           
  Partials      130      130
Impacted Files Coverage Δ
...roller/pravegacluster/pravegacluster_controller.go 54.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7e242f...4354502. Read the comment docs.

anishakj commented 2 years ago

@realAaronWu , For chart changes you may have to raise new PR in https://github.com/pravega/charts/. Charts from this repository are deprecated

anishakj commented 2 years ago

@realAaronWu Could you please confirm that you have verified with finalizer enabled and disabled?

realAaronWu commented 2 years ago

@anishakj I tested both enable and disble finalizer for pravega cluster ,both work as expected.