search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 591: Adding support for configuring liveness and readiness probes #592

Closed anishakj closed 2 years ago

anishakj commented 2 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

Currently the liveness and readiness probe values are not configurable for segment store and controller pods.

Purpose of the change

Fixes #591

What the code does

Added a new field in CRD for ControllerProbes and SegementStoreProbes and while creating the pod spec, use the values supplied by the user. If values are not provided use default values

How to verify it

Verified that able to configure probes for segment store and controller pods

codecov-commenter commented 2 years ago

Codecov Report

Merging #592 (d153f9c) into master (f833dc5) will increase coverage by 0.43%. The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   74.35%   74.78%   +0.43%     
==========================================
  Files          16       16              
  Lines        4258     4339      +81     
==========================================
+ Hits         3166     3245      +79     
- Misses        962      963       +1     
- Partials      130      131       +1
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/zz_generated.deepcopy.go 99.03% <94.11%> (-0.44%) :arrow_down:
pkg/apis/pravega/v1beta1/pravega.go 98.74% <100.00%> (+0.39%) :arrow_up:
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f833dc5...d153f9c. Read the comment docs.