search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 601: Upgrading Pravega minor version is failing with test mode enabled #602

Closed anishakj closed 2 years ago

anishakj commented 2 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

when test mode is enabled, rollback timeout is not set to any default value. Due to that upgrade is not getting any time to complete and is failing

Purpose of the change

Fixes #601

What the code does

Set the Rollback timeout to 10 min even if test mode is enabled

How to verify it

Verified that upgrade is working fine with test mode is enabled.

codecov-commenter commented 2 years ago

Codecov Report

Merging #602 (88c6530) into master (2b65398) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          16       16           
  Lines        4479     4479           
=======================================
  Hits         3361     3361           
  Misses        984      984           
  Partials      134      134
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go 98.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b65398...88c6530. Read the comment docs.