search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 607: add toleration support for controller and segmentStore pods #608

Closed alfred-landrum closed 2 years ago

alfred-landrum commented 2 years ago

Signed-off-by: Alfred Landrum alfred@leakybucket.org

Change log description

Allow specifying tolerations for the controller and segment store pods.

Purpose of the change

Closes https://github.com/pravega/pravega-operator/issues/607

anishakj commented 2 years ago

@alfred-landrum Thanks for the contribution. Could you please make a PR for chart changes in https://github.com/pravega/charts

alfred-landrum commented 2 years ago

Part of a group of PR's to support pod tolerations:

bookkeeper operator: https://github.com/pravega/bookkeeper-operator/pull/193

pravega operator: https://github.com/pravega/pravega-operator/pull/608

charts: https://github.com/pravega/charts/pull/117

anishakj commented 2 years ago

@alfred-landrum Could you please resolve conflicts. Also could you try to generate crds using controller-gen tool and let us know if there are any issues

codecov-commenter commented 2 years ago

Codecov Report

Merging #608 (5df3f0c) into master (ed18236) will decrease coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   82.95%   82.81%   -0.14%     
==========================================
  Files          17       17              
  Lines        4100     4068      -32     
==========================================
- Hits         3401     3369      -32     
  Misses        565      565              
  Partials      134      134
Impacted Files Coverage Δ
api/v1alpha1/zz_generated.deepcopy.go 100.00% <ø> (ø)
api/v1beta1/pravega.go 98.88% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go 99.00% <100.00%> (-0.04%) :arrow_down:
controllers/pravega_controller.go 100.00% <100.00%> (ø)
controllers/pravega_segmentstore.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed18236...5df3f0c. Read the comment docs.