pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 620: Fix for pravega upgrade failure #627

Closed anishakj closed 2 years ago

anishakj commented 2 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

While doing upgrade of pravega cluster, we are finding outdated pod in segment store using the pravega cluster labels. Since the controller and segment store share the same labels, outdated pod lists controller pod as well and upgrade is not happening correctly.

Purpose of the change

Fixes #620

What the code does

Corrected the labels for finding outdated pod

How to verify it

Verified that upgrade is working fine

codecov-commenter commented 2 years ago

Codecov Report

Merging #627 (f0da663) into master (43108bf) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   82.81%   82.82%           
=======================================
  Files          17       17           
  Lines        4068     4069    +1     
=======================================
+ Hits         3369     3370    +1     
  Misses        565      565           
  Partials      134      134           
Impacted Files Coverage Δ
controllers/upgrade.go 72.97% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43108bf...f0da663. Read the comment docs.