search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 630: Updating controller pdb policy #631

Closed anishakj closed 2 years ago

anishakj commented 2 years ago

Signed-off-by: anishakj anisha.kj@dell.com

Change log description

Updating the controller PDB policy

Purpose of the change

Fixes #630

What the code does

Currently in controller PDB, the maxunavailableReplicas set in values file is used for minAvailable . Corrected the policy. Also if the replica count is 1 setting maxunavailable replicas to 0 as in segment store

How to verify it

Verified that able to configure PDB with these settings

codecov-commenter commented 2 years ago

Codecov Report

Merging #631 (57f08b1) into master (4092987) will decrease coverage by 0.03%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   82.82%   82.78%   -0.04%     
==========================================
  Files          17       17              
  Lines        4069     4073       +4     
==========================================
+ Hits         3370     3372       +2     
- Misses        565      566       +1     
- Partials      134      135       +1
Impacted Files Coverage Δ
controllers/pravega_controller.go 99.35% <66.66%> (-0.65%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4092987...57f08b1. Read the comment docs.