search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 632: Upgrade of pravega cluster is failing intermittently #633

Closed anishakj closed 2 years ago

anishakj commented 2 years ago

Signed-off-by: anisha.kj anisha.kj@dell.com

Change log description

In some cases, after updating stateful set, updatedReplicas field in sts is not updating correctly. Due to this, the check 

if sts.Status.UpdatedReplicas == sts.Status.Replicas &&
        sts.Status.UpdatedReplicas == sts.Status.ReadyReplicas

is succeeding and make upgrade as completed. And segment store pods are not coming up with new image

Purpose of the change

Fixes #632

What the code does

Added additional check to ensure that all the pods are updated with new version

How to verify it

Verified that upgrade is working fine

codecov-commenter commented 2 years ago

Codecov Report

Merging #633 (8be60e5) into master (323a35a) will increase coverage by 0.08%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   82.83%   82.92%   +0.08%     
==========================================
  Files          17       17              
  Lines        4073     4075       +2     
==========================================
+ Hits         3374     3379       +5     
+ Misses        565      562       -3     
  Partials      134      134
Impacted Files Coverage Δ
controllers/upgrade.go 72.81% <60.00%> (-0.17%) :arrow_down:
controllers/pravegacluster_controller.go 55.69% <100.00%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 323a35a...8be60e5. Read the comment docs.