pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 634: Segment store pods are not restarted for labels updation #635

Closed anishakj closed 1 year ago

anishakj commented 1 year ago

Signed-off-by: anisha.kj anisha.kj@dell.com

Change log description

While doing restart of sts, labels are not passed correctly to list pods. Corrected the labels

Purpose of the change

Fixes #634

What the code does

Corrected the labels, so that the pods are listed and restarted correctly

How to verify it

Verified that after changing segment store pod labels, pods are restarted

codecov-commenter commented 1 year ago

Codecov Report

Merging #635 (a699891) into master (01093bb) will decrease coverage by 0.04%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   82.92%   82.87%   -0.05%     
==========================================
  Files          17       17              
  Lines        4075     4077       +2     
==========================================
  Hits         3379     3379              
- Misses        562      564       +2     
  Partials      134      134              
Impacted Files Coverage Δ
controllers/pravegacluster_controller.go 55.52% <0.00%> (-0.18%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anishakj commented 1 year ago

@vgupta-mickey there we have to make some more changes to restart pods, if sts fields are changed. I am working on it