search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Missing NodeSelector or Affinity support in the Pravega-Operator helm chart #640

Open jensjohansen opened 1 year ago

jensjohansen commented 1 year ago

Description

Our k8s cluster has both ARM and AMD X86 processors, so we need either affinity: {} or nodeSelector:{} to work in the helm chart for Pravega Operator.

Importance

Blocker

Location

templates/operator.yaml needs to include the same affinity support that the Pravega/Zookeeper-operator has.

Suggestions for an improvement

Add the following code at about line 21 in templates/operator.yaml

      {{- if .Values.nodeSelector }}
      nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
      {{- end }}
      {{- if .Values.affinity }}
      affinity:
{{ toYaml .Values.affinity | indent 8 }}
      {{- end }}
      {{- if .Values.tolerations }}
      tolerations:
{{ toYaml .Values.tolerations | indent 8 }}
      {{- end }}

And add the empty place holders around line 18 in values.yaml:

# Scheduling constraints
nodeSelector: {}
affinity: {}
tolerations: []