pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 643: Pravega cluster upgrade is failing intermittently #644

Closed anishakj closed 1 year ago

anishakj commented 1 year ago

Signed-off-by: anisha.kj anisha.kj@dell.com

Change log description

Pravega cluster upgrade is failing in certain cases. In failed scenarios, while deleting the pod, we are getting error pod not found. Due to that error upgrade status is set to failure and due to that subsequent upgrade of pods is not happening

Purpose of the change

Fixes #643

What the code does

Made changes to not return error in the case of pod deletion fails with pod not found error. This ensures that remaining pods can be upgraded successfully.

How to verify it

Verified upgrade of pravega cluster multiple times and is successful

codecov-commenter commented 1 year ago

Codecov Report

Base: 82.87% // Head: 82.75% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (eb5d671) compared to base (4d2f367). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #644 +/- ## ========================================== - Coverage 82.87% 82.75% -0.13% ========================================== Files 17 17 Lines 4077 4083 +6 ========================================== Hits 3379 3379 - Misses 564 567 +3 - Partials 134 137 +3 ``` | [Impacted Files](https://codecov.io/gh/pravega/pravega-operator/pull/644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [api/v1beta1/pravega.go](https://codecov.io/gh/pravega/pravega-operator/pull/644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-YXBpL3YxYmV0YTEvcHJhdmVnYS5nbw==) | `98.88% <ø> (ø)` | | | [controllers/pravega\_segmentstore.go](https://codecov.io/gh/pravega/pravega-operator/pull/644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvcHJhdmVnYV9zZWdtZW50c3RvcmUuZ28=) | `98.70% <0.00%> (-1.30%)` | :arrow_down: | | [controllers/upgrade.go](https://codecov.io/gh/pravega/pravega-operator/pull/644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvdXBncmFkZS5nbw==) | `72.81% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.