codecov-commenter
commented
1 year ago Codecov Report
Base: 82.75% // Head: 82.75% // No change to project coverage :thumbsup:
Coverage data is based on head (
a47d997) compared to base (6866e3c). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #645 +/- ## ======================================= Coverage 82.75% 82.75% ======================================= Files 17 17 Lines 4083 4083 ======================================= Hits 3379 3379 Misses 567 567 Partials 137 137 ``` | [Impacted Files](https://codecov.io/gh/pravega/pravega-operator/pull/645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [controllers/upgrade.go](https://codecov.io/gh/pravega/pravega-operator/pull/645/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvdXBncmFkZS5nbw==) | `72.81% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Signed-off-by: anisha.kj anisha.kj@dell.com
Change log description
In some cases, while updating segment store pods, upgrade is failing with error
Failed to get outdated pod. When this happens all the SS pods are already updated.Purpose of the change
Fixes #643
What the code does
While upgrading segment store pods, even if the pods are updated with new version it takes some time to reflect in the status. So upgrade reconcile loop thinks upgrade is not completed and try to get an outdated pod. Since the pods are already updated, it fails to get outdated pod and makes upgrade as failed. Added an extra check not to update the pod if all the pods are updated to target version
How to verify it
Performed couple of upgrades and verified they are working fine.