search

pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 661: Removing the check of controller minimum replicas from operator #662

Closed anishakj closed 1 year ago

anishakj commented 1 year ago

Change log description

Adding the support additional port in segment store service

Purpose of the change

Fixes #661

What the code does

Removed the check of mandating controller replica to 1

How to verify it

Removed the check of mandating controller replica to 1 currently the check for minimum controller replicas is removed, because during LTS recovery we need to stop all the requests from controller. In order to achieve this we are allowing 0 controller replicas.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (a1dcfec) 82.67% compared to head (f7f7324) 82.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #662 +/- ## ========================================== - Coverage 82.67% 82.66% -0.02% ========================================== Files 17 17 Lines 4099 4096 -3 ========================================== - Hits 3389 3386 -3 Misses 571 571 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/pravega/pravega-operator/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [api/v1beta1/pravega.go](https://codecov.io/gh/pravega/pravega-operator/pull/662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-YXBpL3YxYmV0YTEvcHJhdmVnYS5nbw==) | `98.86% <ø> (-0.02%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://codecov.io/gh/pravega/pravega-operator/pull/662/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.