pravega / pravega-operator

Pravega Kubernetes Operator
Apache License 2.0
41 stars 38 forks source link

Issue 666: Expose new port to segment store services #667

Closed anishakj closed 11 months ago

anishakj commented 11 months ago

Change log description

Exposing the port 9999 to segment store services

Purpose of the change

Fixes #666

What the code does

Added support for additional port in segment store services. Also provided the option to add the extra port at run time using the option pravegaservice.admin.listener.port

How to verify it

Verified by installing pravega and verified that new port is coming in the service

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.30% :warning:

Comparison is base (aac1646) 82.66% compared to head (bd4358d) 82.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #667 +/- ## ========================================== - Coverage 82.66% 82.36% -0.30% ========================================== Files 17 17 Lines 4096 4129 +33 ========================================== + Hits 3386 3401 +15 - Misses 571 583 +12 - Partials 139 145 +6 ``` | [Files Changed](https://app.codecov.io/gh/pravega/pravega-operator/pull/667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [controllers/pravegacluster\_controller.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvcHJhdmVnYWNsdXN0ZXJfY29udHJvbGxlci5nbw==) | `54.86% <9.09%> (-1.41%)` | :arrow_down: | | [controllers/pravega\_segmentstore.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvcHJhdmVnYV9zZWdtZW50c3RvcmUuZ28=) | `98.74% <100.00%> (+0.03%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.