codecov-commenter
commented
12 months ago Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
Comparison is base (
2d60c29) 82.37% compared to head (3986b90) 82.27%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #672 +/- ## ========================================== - Coverage 82.37% 82.27% -0.10% ========================================== Files 17 17 Lines 4130 4136 +6 ========================================== + Hits 3402 3403 +1 - Misses 583 586 +3 - Partials 145 147 +2 ``` | [Files](https://app.codecov.io/gh/pravega/pravega-operator/pull/672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [controllers/upgrade.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvdXBncmFkZS5nbw==) | `72.04% <16.66%> (-0.77%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Change log description
Fixing intermittent upgrade failure of pravega. Added some more conditions to handle error scenarios
Purpose of the change
Fixes #643
What the code does
while during segmentstore update, it fails to get the pod sometimes. Issue is happening because while it tries to get an outdated pod, it has already updated. So added more checks to post error only if all pods were not updated
How to verify it
Peformed upgrade multiple time and issue is not seen