codecov-commenter
commented
8 months ago Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.
Comparison is base (
7f7f64a) 82.27% compared to head (f51da35) 82.11%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #675 +/- ## ========================================== - Coverage 82.27% 82.11% -0.17% ========================================== Files 17 17 Lines 4136 4149 +13 ========================================== + Hits 3403 3407 +4 - Misses 586 593 +7 - Partials 147 149 +2 ``` | [Files](https://app.codecov.io/gh/pravega/pravega-operator/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [api/v1beta1/pravegacluster\_types.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-YXBpL3YxYmV0YTEvcHJhdmVnYWNsdXN0ZXJfdHlwZXMuZ28=) | `90.23% <ø> (ø)` | | | [controllers/pravega\_segmentstore.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvcHJhdmVnYV9zZWdtZW50c3RvcmUuZ28=) | `97.94% <60.00%> (-0.81%)` | :arrow_down: | | [pkg/util/pravegacluster.go](https://app.codecov.io/gh/pravega/pravega-operator/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-cGtnL3V0aWwvcHJhdmVnYWNsdXN0ZXIuZ28=) | `95.26% <0.00%> (-2.58%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Change log description
While deploying pravega with 12 segmentstore pods, segmentstore service was using one of the ports used by other service
containerdand was causing conflict Added new spec field in CRD asreservedPortListand while assigning port to service ensure that it is not in reserved port ListPurpose of the change
Fixes #674
What the code does
Assigning port to segment store services which is not in the reserved portList, if it finds conflict next port will be assigned.
How to verify it
Verified pravega installation with 12 segmentstore pods and ensured that ports mentioned in reservedportlist are getting skipped.