search

pravega / schema-registry

Pravega Schema Registry repository
Apache License 2.0
15 stars 23 forks source link

Enable shadowing and relocating in serializer #101

Closed crazyzhou closed 4 years ago

crazyzhou commented 4 years ago

Problem description As now the serializer module is using a shaded jar without shading. This might cause conflicts with the projects which uses this as a dependency. We need to provide a shaded jar for this.

Problem location build.gradle

Suggestions for an improvement Enable shadowing and relocating dependenct packages in serializer module

crazyzhou commented 4 years ago

Another related problem for this: Should we leave pravega-client as a provided dependency? I think most applications using the registry will have pravega-client in the jar file. It may be a direct one in a normal java app or contained inside the connector in a Flink/Spark app. For pravega-client dependency, can we simply mark the pravega-client compileOnly as we do the same as in keycloak client? https://github.com/pravega/pravega-keycloak/blob/7a02c4b5f127064281d60e93b6aa8d48178e57e1/build.gradle#L82