pravega / schema-registry

Pravega Schema Registry repository
Apache License 2.0
15 stars 23 forks source link

Default helm chart `controllerUri` value #250

Closed derekm closed 1 year ago

derekm commented 2 years ago

Problem description In the Schema Registry helm chart the default controllerUri is tcp:localhost:9090.

This may be helpful when running your schema registry from the same pod as your pravega controller, however, when using the pravega helm charts with a release name of “pravega”, the default controller uri would be the service created, which is tcp://pravega-pravega-controller:9090.

Problem location https://github.com/pravega/schema-registry/blob/master/charts/schema-registry/README.md?plain=1#L68 https://github.com/pravega/schema-registry/blob/master/charts/schema-registry/values.yaml#L82

Suggestions for an improvement The service name is {user defined helm release name}-pravega-controller.