search

pravega / schema-registry

Pravega Schema Registry repository
Apache License 2.0
15 stars 23 forks source link

Updated default coordinator URI and image tag in helm chart values.yaml #251

Closed tsteinholz closed 2 years ago

tsteinholz commented 2 years ago

Change log description

Updated the default Controller URI to match the default pravega helm charts since localhost would not be valid given the image used in the k8 helm chart environment.

Purpose of the change

Addresses #250

This PR allows the schema registry helm charts to be compatible with the Pravega helm charts when following the Pravega Kubernetes 101 Guide.

The guide states to install the pravega charts via the pravega release name: helm install pravega pravega/pravega --version=0.8.0, which will default to creating the controller service in the ClusterIP with the internal dns of "pravega-pravega-controller".

What the code does

No code change, just default configuration.

How to verify it

Follow the Pravega Kubernetes 101 Guide and then install the schema registry charts with default values.

shshashwat commented 2 years ago

@tsteinholz , thank you for your contribution. As a first rule, all commits need to signed-off which is missing from this PR. Please follow:- https://github.com/pravega/pravega/wiki/Contributing

tsteinholz commented 2 years ago

HI @shshashwat, I have rebased the commits to include the sign off - seems like the checks are passing now.

I also took the chance to update the default image to the latest available.

tsteinholz commented 2 years ago

Can't update the branch from my repo, need to create a new PR (#253) to follow the guidelines.