search

pravega / schema-registry

Pravega Schema Registry repository
Apache License 2.0
15 stars 23 forks source link

Issue 250: improvement/helm chart defaults 0.4 #253

Closed tsteinholz closed 2 years ago

tsteinholz commented 2 years ago

Re-Issuance of PR #251 following the the contributing guide.

I also updated the default image tag version to the latest version.

Change log description

Updated the default Controller URI to match the default pravega helm charts since localhost would not be valid given the image used in the k8 helm chart environment.

Purpose of the change

Addresses #250

This PR allows the schema registry helm charts to be compatible with the Pravega helm charts when following the Pravega Kubernetes 101 Guide.

The guide states to install the pravega charts via the pravega release name: helm install pravega pravega/pravega --version=0.8.0, which will default to creating the controller service in the ClusterIP with the internal dns of "pravega-pravega-controller".

What the code does

No code change, just default configuration.

How to verify it

Follow the Pravega Kubernetes 101 Guide and then install the schema registry charts with default values.

RaulGracia commented 2 years ago

@shshashwat this PR, in fact, only changes the charts file. I don't know why this is showing a change in gradle.properties, because it is not changing anything (it already has the values that are already there).

shshashwat commented 2 years ago

@shshashwat this PR, in fact, only changes the charts file. I don't know why this is showing a change in gradle.properties, because it is not changing anything (it already has the values that are already there).

I think it's showing changes because of the tip of the head wasn't pointing to the latest master and after creating a PR when the latest was updated it was updated on current branch rather than the master itself. This PR needs a rebase with the latest master synced with forked master. These changes will go with that.

shshashwat commented 2 years ago

@tsteinholz, can you please update your master and rebase this branch with latest master? That way we would be able to close this soon.

shshashwat commented 2 years ago

Closing this PR as didn't get any response. A re-creation of this PR is merged to master.