zoo.cfg not getting modified.

gimpiron commented 4 years ago

Description

Hey, so im trying to deploy zookeeper cluster with the following modification;

apiVersion: "zookeeper.pravega.io/v1beta1"
kind: "ZookeeperCluster"
metadata:
  name: "zookeeper"
spec:
  replicas: 3
  config:
    tickTime: 2000
    initLimit: 10
    syncLimit: 5
    clientPort: 2181
    maxClientCnxns: 2000
    maxSessionTimeout: 60000000
    autopurge.snapRetainCount: 3
    autopurge.purgeInterval: 1
    preAllocSize: 131072
    snapCount: 3000000
    reconfigEnabled: true
    4lw.commands.whitelist: "*"
    dataDir: "/data/zookeeper"

Sadly, i cannot see my changes inside my pod at /data/cong/zoo.cfg. Morover, I cant see the changes the zookeeper configmap:

zoo.cfg:
----
4lw.commands.whitelist=cons, envi, conf, crst, srvr, stat, mntr, ruok
dataDir=/data
standaloneEnabled=false
reconfigEnabled=true
skipACL=yes
metricsProvider.className=org.apache.zookeeper.metrics.prometheus.PrometheusMetricsProvider
metricsProvider.httpPort=7000
metricsProvider.exportJvmInfo=true
initLimit=10
syncLimit=5
tickTime=2000
quorumListenOnAllIPs=false
dynamicConfigFile=/data/zoo.cfg.dynamic

What am I missing? are all config options are configurable?

Importance

blocker

Suggestions for an improvement

More documentation about possible options and where the config file is located & used.

amuraru commented 4 years ago

Dupe of #222 ?

gimpiron commented 4 years ago

@amuraru I took a look at your issue as well, I am not sure its the same one, I cant find my changes at /conf/zoo.cfg aither. Important to emphasize that I cant see my changes right from the first deployment of my yaml.

anishakj commented 4 years ago

Currently all the config parameters we are not supporting in zoo.cfg, that is why you are not seeing it in first deployment. We will work on this enhancement soon.

gimpiron commented 4 years ago

Ok, following! thanks for the answer

AceHack commented 4 years ago

When will you support autopurge.snapRetainCount: 3 autopurge.purgeInterval: 1

We need this ASAP

pinkeshsharma commented 4 years ago

This is a blocker for us as well ...

anishakj commented 4 years ago

Fixed by PR https://github.com/pravega/zookeeper-operator/pull/262

pravega / zookeeper-operator