pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
368 stars 207 forks source link

Support configure annotations for zookeeper pod again #274

Closed fokkoru closed 4 years ago

fokkoru commented 4 years ago

Description

It looks to me like a bug. Could be related to #125, #249, #260

I try to apply kubectl apply -f zk.yam the following config on GKE

apiVersion: zookeeper.pravega.io/v1beta1
kind: ZookeeperCluster
metadata:
  name: zookeeper
spec:
  replicas: 3
  persistence:
    spec:
      storageClassName: pd-ssd
      resources:
        requests:
          storage: 500Gi
  pod:
    annotations:
      ad.datadoghq.com/zookeeper.check_names: '["zk"]'
      ad.datadoghq.com/zookeeper.init_configs: '[{}]'
      ad.datadoghq.com/zookeeper.instances: '[{"host": "%%host%%", "port": "2181"}]'

but after I can't find those annotations on pods. What did I wrong? A version of zookeeper-operator is 0.2.9.

Importance

must-have

Location

Configure the annotations of .spec.pod.annotations, but check the zookeeper instance, annotations don't appear in the pod spec.

Suggestions for an improvement

Can we use .spec.pod.annotations to configure the zookeeper pods annotations?

anishakj commented 4 years ago

Fix will be available only in zookeeper-operator 0.3.0. For time being you can build custom image and use it.

fokkoru commented 4 years ago

@anishakj when do you plan to release 0.3.0?

anishakj commented 4 years ago

@anishakj when do you plan to release 0.3.0?

Mostly in another 2 months