search

pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
368 stars 207 forks source link

Issue 475: use socat instead of nc #476

Closed alfred-landrum closed 2 years ago

alfred-landrum commented 2 years ago

Signed-off-by: Alfred Landrum alfred@leakybucket.org

Change log description

Replace usage of nc with socat for zookeeper 4 letter word commands.

Purpose of the change

Fixes #475

codecov[bot] commented 2 years ago

Codecov Report

Base: 85.05% // Head: 85.05% // No change to project coverage :thumbsup:

Coverage data is based on head (d76a433) compared to base (ae23010). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## ======================================= Coverage 85.05% 85.05% ======================================= Files 12 12 Lines 1606 1606 ======================================= Hits 1366 1366 Misses 155 155 Partials 85 85 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Slach commented 2 years ago

@anishakj build pass, could you merge PR?

anishakj commented 2 years ago

@alfred-landrum Could you please run e2e tests using the zookeeper image

Slach commented 2 years ago

@alfred-landrum could you merge master to your branch?

mailsonsantana commented 2 years ago

Hi @derekm Any predictions to approve?