Closed endzyme closed 1 year ago
@anishakj if you point me in the right direction, I can make a PR.
I am thinking there are two approaches.
Any thoughts or alternatives?
@anishakj if you point me in the right direction, I can make a PR.
I am thinking there are two approaches.
- Remove the spec.pod.labels from the CRD
- Make the behavior the same as spec.labels and document which spec keys override one another
- Change the behavior so spec.labels only applies labels to statefulset and let spec.pod.labels be the place for pod label customization
Any thoughts or alternatives?
I ended up taking approach 2.
Description
The
zookeepercluster.spec.pod.labels
are not applied to the final pods or the StatefulSet created by the Zookeeper Operator.Importance
should-have
: If it's in the spec, it should work as intended or be removed.blocker
: Since the Solr Operator uses this Zookeeper Operator, it is currently blocking us from adding custom labels to Zookeeper Clusters created with the Solr Operator.Location
Unsure, would need some help to track it down, but is likely related to https://github.com/pravega/zookeeper-operator/issues/257.
Suggestions for an improvement
Taking into account the features or https://github.com/pravega/zookeeper-operator/issues/257, this should have a merge between the two maps and apply the final merge to the template spec of the StatefulSet.