pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
369 stars 203 forks source link

can't set imagePullSecrets on post-install job #551

Open TomBillietKlarrio opened 1 year ago

TomBillietKlarrio commented 1 year ago

Description

It's not possible to set imagePullSecret credentials on the post-install job. You can configure the repository where it's pulled from, but if that repository needs authentication, it's not possible to set it. It should respect the settings from global/imagePullSecrets

Importance

This is a blocker for us, since we're only allowed to pull images from our internal repository (which requires authentication)

Location

https://github.com/pravega/zookeeper-operator/blob/72bea545a73130c82b530e508a2a14daaa824435/charts/zookeeper-operator/templates/post-install-upgrade-hooks.yaml#L46

Suggestions for an improvement

Add the same logic as in the regular service-account: https://github.com/pravega/zookeeper-operator/blob/72bea545a73130c82b530e508a2a14daaa824435/charts/zookeeper-operator/templates/service_account.yaml#L5