pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
368 stars 207 forks source link

Upgrade K8s dependencies to be compatible with 1.25 #563

Closed panyuenlau closed 1 year ago

panyuenlau commented 1 year ago

Change log description

Upgrade K8s dependencies to be compatible with 1.25

Purpose of the change

Make zookeeper-operator compatible with K8s 1.25

What the code does

K8s dependencies upgrade.

How to verify it

Build the image, run it in K8s cluster with 1.25

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9d283c2) 85.12% compared to head (d49f067) 85.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #563 +/- ## ======================================= Coverage 85.12% 85.12% ======================================= Files 12 12 Lines 1613 1613 ======================================= Hits 1373 1373 Misses 155 155 Partials 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

panyuenlau commented 1 year ago

Hey @anishakj, can you please take a quick look at this short PR when you have some time?

And I am also wondering what's the plan for dropping the next release.

anishakj commented 1 year ago

@panyuenlau E2E tests are failing in your PR. please have a look. Probably you need to update K8 version here https://github.com/pravega/zookeeper-operator/blob/master/.github/workflows/ci.yaml#L42

panyuenlau commented 1 year ago

@panyuenlau E2E tests are failing in your PR. please have a look. Probably you need to update K8 version here https://github.com/pravega/zookeeper-operator/blob/master/.github/workflows/ci.yaml#L42

Hey @anishakj - my changes shouldn't cause zookeeper-operator not support K8s 1.23 since I've checked that no deprecated APIs for K8s 1.25 are being used in zookeeper-operator.

And all the tests passed when I run the e2e tests via make test-e2e against an EKS cluster with 1.23.17. Not exactly sure why the tests are failing in CI with minikube.