pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
364 stars 203 forks source link

the default snapCount configuration mismatch the comment. #564

Open sangheee opened 1 year ago

sangheee commented 1 year ago

Change log description

The default value of snapCount that the comment says is 100,000. But the actual value is set at 10,000. I corrected this mismatch between them.

Purpose of the change

None

What the code does

How to verify it

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9d283c2) 85.12% compared to head (b9aaa6d) 85.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #564 +/- ## ======================================= Coverage 85.12% 85.12% ======================================= Files 12 12 Lines 1613 1613 ======================================= Hits 1373 1373 Misses 155 155 Partials 85 85 ``` | [Impacted Files](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [api/v1beta1/zookeepercluster\_types.go](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-YXBpL3YxYmV0YTEvem9va2VlcGVyY2x1c3Rlcl90eXBlcy5nbw==) | `98.80% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

anishakj commented 9 months ago

@sangheee Here the comment needs to be corrected, default snapshot count is 10000 https://zookeeper.apache.org/doc/r3.1.2/zookeeperAdmin.html