pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
364 stars 203 forks source link

Bump kub libs #568

Closed AKamyshnikova closed 9 months ago

AKamyshnikova commented 1 year ago

Signed-off-by: Ann Taraday akamyshnikova@mirantis.com

Change-Id: Ia673486d8ebb3c76e86d1cc3af846cd890b4ffaa

Change log description

Updated usage for fake client - now required WithStatusSubresource(..)

Purpose of the change

Fixes: #567

What the code does

(Detailed description of the code changes)

How to verify it

All e2e tests should pass

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28d1f69) 85.12% compared to head (1159ce0) 85.12%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 85.12% 85.12% ======================================= Files 12 12 Lines 1613 1613 ======================================= Hits 1373 1373 Misses 155 155 Partials 85 85 ``` | [Files](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega) | Coverage Δ | | |---|---|---| | [api/v1beta1/zookeepercluster\_types.go](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-YXBpL3YxYmV0YTEvem9va2VlcGVyY2x1c3Rlcl90eXBlcy5nbw==) | `98.80% <ø> (ø)` | | | [controllers/zookeepercluster\_controller.go](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-Y29udHJvbGxlcnMvem9va2VlcGVyY2x1c3Rlcl9jb250cm9sbGVyLmdv) | `65.46% <100.00%> (ø)` | | | [pkg/yamlexporter/exportutil.go](https://app.codecov.io/gh/pravega/zookeeper-operator/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pravega#diff-cGtnL3lhbWxleHBvcnRlci9leHBvcnR1dGlsLmdv) | `61.90% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AKamyshnikova commented 1 year ago

Run e2e tests locally and they passed

• [SLOW TEST:585.533 seconds]
Perform rolling restart on zk cluster
/root/zookeeper-operator/test/e2e/rolling_restart_test.go:20
  Check rolling restart operation
  /root/zookeeper-operator/test/e2e/rolling_restart_test.go:21
    should perform rolling restart
    /root/zookeeper-operator/test/e2e/rolling_restart_test.go:22
------------------------------
STEP: tearing down the test environment

Ran 8 of 8 Specs in 3469.747 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (3469.75s)
PASS
ok      github.com/pravega/zookeeper-operator/test/e2e  3469.779s
make undeploy
anishakj commented 1 year ago

Run e2e tests locally and they passed

• [SLOW TEST:585.533 seconds]
Perform rolling restart on zk cluster
/root/zookeeper-operator/test/e2e/rolling_restart_test.go:20
  Check rolling restart operation
  /root/zookeeper-operator/test/e2e/rolling_restart_test.go:21
    should perform rolling restart
    /root/zookeeper-operator/test/e2e/rolling_restart_test.go:22
------------------------------
STEP: tearing down the test environment

Ran 8 of 8 Specs in 3469.747 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestAPIs (3469.75s)
PASS
ok      github.com/pravega/zookeeper-operator/test/e2e  3469.779s
make undeploy

@AKamyshnikova could you please check if there is change in CRD file generated? If there is change please check in the CRD file too

AKamyshnikova commented 1 year ago

@anishakj Thanks for pointing this! Updated CRDs

anishakj commented 10 months ago

@AKamyshnikova Could you please resolve conflicts?