Closed joshsouza closed 8 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
88b9307
) 85.12% compared to head (794565c
) 85.91%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
controllers/zookeepercluster_controller.go | 70.00% | 3 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Has there been any testing done to prove that the modified chart allows exposing metrics for Prometheus?
Has there been any testing done to prove that the modified chart allows exposing metrics for Prometheus?
I utilized helm template when writing the code to ensure the appropriate adjustments to the k8s resources, and deploying it to a local kind cluster before/after with a second curl
pod deployed to test connectivity validates that without these changes I am unable to curl <pod_ip>:6000/metrics
(connection refused) beforehand, and with --set metricsBindAddress=0.0.0.0
in my helm update/install parameters, I am able to successfully reach the metrics endpoint from my curl
pod afterwards.
While I didn't explicitly test that Prometheus itself was working, this should be a sufficient test to verify that the changes are functioning as intended, and should allow metrics gathering by other pods in the cluster.
Resolves: https://github.com/pravega/zookeeper-operator/issues/581