search

pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
368 stars 206 forks source link

Add imagePullSecrets to Helm Hooks in Zookeeper_Operator charts #589

Closed krishnadas-menon closed 5 months ago

krishnadas-menon commented 10 months ago

Description

Currently the service accounts/Job definitions of Zookeeper-Operator Helm hooks doesn't have a way to incorporate the imagepull secrets.

Importance

MustHave

Location

https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L39-L47 https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/pre-delete-hooks.yaml#L39-L47

Suggestions for an improvement

Will try to add the global.imagePullSecrets or hooks.serviceAccount.imagePullSecrets section under serviceaccount for hooks