Closed unguiculus closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9fc6151
) 85.91% compared to head (7fa4bdb
) 85.91%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jkhalack Would you be able to have a look at this change? It would be really appreciated to get this change added to the helm charts. TIA
@anishakj Could you please help me with the timeline for this change to be released. Appreciate if you could expedite the same. Thanks in advance.
Merged as admin.
Change log description
Purpose of the change
Fixes #589
What the code does
Adds imagePullSecrets to the YAML for the ServiceAccounts for the Helm hooks. This is important when images are pulled from a private registry, e.g. an internal proxy, such as Artifactory, or when using custom images.
How to verify it
Render the templates using the following command: