pravega / zookeeper-operator

Kubernetes Operator for Zookeeper
Apache License 2.0
367 stars 202 forks source link

Issue 589: Add imagePullSecrets for Helm hooks #591

Closed unguiculus closed 4 months ago

unguiculus commented 9 months ago

Change log description

Purpose of the change

Fixes #589

What the code does

Adds imagePullSecrets to the YAML for the ServiceAccounts for the Helm hooks. This is important when images are pulled from a private registry, e.g. an internal proxy, such as Artifactory, or when using custom images.

How to verify it

Render the templates using the following command:

helm template zookeeper charts/zookeeper-operator \
    --show-only templates/post-install-upgrade-hooks.yaml \
    --show-only templates/pre-delete-hooks.yaml \
    --set hooks.serviceAccount.imagePullSecrets={'my-pull-secret'}
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9fc6151) 85.91% compared to head (7fa4bdb) 85.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #591 +/- ## ======================================= Coverage 85.91% 85.91% ======================================= Files 12 12 Lines 1633 1633 ======================================= Hits 1403 1403 Misses 145 145 Partials 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

krishnadas-menon commented 6 months ago

@jkhalack Would you be able to have a look at this change? It would be really appreciated to get this change added to the helm charts. TIA

krishnadasm commented 4 months ago

@anishakj Could you please help me with the timeline for this change to be released. Appreciate if you could expedite the same. Thanks in advance.

crazyzhou commented 4 months ago

Merged as admin.