search

pravins / lohit

Lohit fonts family project to supporting Indian scripts.
Other
39 stars 11 forks source link

[lohit-gujarati] Certain consonant characters do not show up fine when clubbed with matras that are positioned either above or below the consonant #34

Closed sudhirb closed 10 years ago

sudhirb commented 10 years ago

This I have observed on Android mobile phones when using the font. For example, When we put an "e"( ે ) or "u" ( ૂ ) Matra on a "k" ( ક ) then the matra appears on the next character not the one where it is applied. This happens with creation consonants only not with all. I have observed with "k" ( ક ) and "chha" ( છ ). Please view the attached screenshot to understand better. screenshot_-----

pravins commented 10 years ago

If will help if you provide more information about same

  1. Version of used software..fonts, android version and specific application name
  2. If possible steps to reproduce issue. (if possible how did you install lohit on Android)
sudhirb commented 10 years ago

The Lohit Gujarati I used is - lohit-gujarati-ttf-2.92.2.tar.gz. Android Version - 4.2.2 Application - any I am using a rooted phone and thus I have installed the font on my entire phone and can view it in any application. This problem can be emulated in any custom made application. Here is a tutorial of how to create a custom application with a custom font - http://www.androidhive.info/2012/02/android-using-external-fonts/

In case you have a rooted phone, you may use this app to install the font - https://play.google.com/store/apps/details?id=com.jrummy.font.installer

pravins commented 10 years ago

I did not understood line "This happens with creation consonants only not with all."

I have tested this at Fedora 19 and it is working fine. I will do testing on Android as well but fear it will take some more time.

Till time do report same bug against Android as well. This looks to me more issue from application side rather than font.

sudhirb commented 10 years ago

Sorry I meant "This happens with certain consonants only" For example, the error occurs with ક but not with ગ. "ગ" is all fine.

-Sudhir

On 17-Jan-2014, at 3:48 PM, Pravin Satpute wrote:

I did not understood line "This happens with creation consonants only not with all."

I have tested this at Fedora 19 and it is working fine. I will do testing on Android as well but fear it will take some more time.

Till time do report same bug against Android as well. This looks to me more issue from application side rather than font.

— Reply to this email directly or view it on GitHub.

pravins commented 10 years ago

can you give me some actual words where it happens rather than only consonant and matra?

sudhirb commented 10 years ago

A few example words:

કુદરત કેરલા છંદ છે

-Sudhir

On 17-Jan-2014, at 4:16 PM, Pravin Satpute wrote:

can you give me some actual words where it happens rather than only consonant and matra?

— Reply to this email directly or view it on GitHub.

pravins commented 10 years ago

Thanks a lot.. will update you on same.

pravins commented 10 years ago

We have done number of changes in 2.93.0 version. Please try https://fedorahosted.org/releases/l/o/lohit/lohit-gujarati-ttf-2.5.3.tar.gz and let me know if it works.

sudhirb commented 10 years ago

Same problem persists with 2.5.3 as well.

-Sudhir

On 28-Jan-2014, at 3:59 PM, Pravin Satpute wrote:

We have done number of changes in 2.93.0 version. Please try https://fedorahosted.org/releases/l/o/lohit/lohit-gujarati-ttf-2.5.3.tar.gz and let me know if it works.

— Reply to this email directly or view it on GitHub.

pravins commented 10 years ago

With more analysis with actual device, i observed following thing

  1. This is issue from open type layout shaper (harfbuzz-ng). It is not supporting abvm specifically for gujr script.
  2. Kerning is working fine but it is required only to adjust horizontal distance between two characters. For marks (e-matra) one should use abvm with mark positioning.

So this must be reported to specific upstream with proper steps to reproduce it.

On the other hand there is two tweaks possible to make Lohit work on it.

  1. Adding open type Latin script tag to those tables. This is minor change in Lohit fonts. It is harmless to add in present Lohit Gujarati upstream. If this work with your case that will be great. Font with this change available AT http://pravins.fedorapeople.org/Lohit-Gujarati.ttf Please test it and if this work i will do minor release of Lohit-Gujarati with this change.

If first does not work, there is other option:

  1. Adding dist lookups into Lohit for positioning purpose but it is not standard and recommended and not a long term solution.
sudhirb commented 10 years ago

Just tested the font with the minor change. Unfortunately the minor fix does not work. I guess option 2 is the only viable solution for now.

pravins commented 10 years ago

Updated http://pravins.fedorapeople.org/Lohit-Gujarati.ttf,

  1. Let me know if this works for you. If yes
  2. please let me know the harfbuzz lib version, so i can do minor release specifically for version specified by you.
sudhirb commented 10 years ago

This version works fine and the issue seems fixed. Moreover this issue seems to exists with the Harfbuzz-ng. If we use the older Harfbuzz it seems to be working fine. We are using version 0.9.10 of Harfbuzz-ng.

pravins commented 10 years ago

Thanks for confirmation. I will do minor release specifically for harfbuzz 0.9.10 version and close this issue.

behdad commented 10 years ago

Huh. If nothing else, you should be testing with HarfBuzz master.

behdad commented 10 years ago

0.9.10 is OVER A YEAR old. That's two hackfest's old.

pravins commented 10 years ago

Yes, harfbuzz is performing excellent from last one year :+1: All Lohit fonts giving expected results with harfbuzz ng and we are planning to make them even more efficient with harfbuzz present version.

Sudhir is on the way to release customized smartphone based on android 4.2.2, so this is just short term solution for issue.

But in long term he need to switch to latest harfbuzz version, since this tweak is not going to be part of master branch of Lohit and next releases of lohit-gujarati will again fail.

pravins commented 10 years ago

Lohit Gujarati with fix: https://fedorahosted.org/releases/l/o/lohit/lohit-gujarati-ttf-2.92.2-and-4.2.2.tar.gz

abcork10 commented 10 years ago

Praving...Can you elaborate all these terms... What is harfbuzz, libharfbuzz.so harfbuzz -ng? How to update it?? What is the use of the attached file "lohit-gujarat-ttf-2.92.2-and-4.2.2.tar.gz"? Please... I want to solve the issue in my MMX110...with a custom ROM JMP 12.15 Tornado...Android 4.1.2..Kernel version 3.4.0

pravins commented 10 years ago

About Harfbuzz: http://www.freedesktop.org/wiki/Software/HarfBuzz/ If you are able to reproduce this issues and your harfbuzz version is same as mentioned in this bug. Then

  1. Try to upgrade harfbuzz with latest upstream version. If that is not possible for you use https://fedorahosted.org/releases/l/o/lohit/lohit-gujarati-ttf-2.92.2-and-4.2.2.tar.gz.