Abort installation if version is Python 3

pravj / Doga

:chart_with_upwards_trend: HTTP log monitoring console for Humans

MIT License

241 stars 9 forks source link

Abort installation if version is Python 3 #6

Open microamp opened 10 years ago

microamp commented 10 years ago

This PR stops the installation process from proceeding if the version is Python 3 (which is not currently supported) as discussed in #4.

$ python setup.py install
Sorry, Doga does not support Python 3 at this stage

In addition to the above, I've added 'classifiers' (note that Python 3 is omitted there). Fee free to expand the list if you'd like it to support versions prior to 2.7.

pravj commented 10 years ago

Hi @microamp, So sorry for replying very late, actually I was busy with my exams and things.

Yeah, this PR is right way to divert Python3 users but can you please make sure that this will not limit the users to Python2.7?

If we merge this without checking this out for older Python versions, this will be a wrong thing, I think.

microamp commented 9 years ago

Hi @pravj,

My apologies on my late reply.

What Python 2 versions are you targetting apart from Python 2.7? So far, I've only tested it with 2.7 personally. I guess having a test suite would make things easier (CI (e.g. Travis) with the versions to support specified) although I'm not sure how trivial to write them for this particular application. Are you planning to write one in the near future?