search

praw-dev / praw

PRAW, an acronym for "Python Reddit API Wrapper", is a python package that allows for simple access to Reddit's API.
http://praw.readthedocs.io/
BSD 2-Clause "Simplified" License
3.4k stars 453 forks source link

Window size config #1975

Open Watchful1 opened 9 months ago

Watchful1 commented 9 months ago

Super bare bones initial implementation of passing a config value for window size into prawcore. Just wanted to have something down so I can feel like I started on it.

LilSpazJoekp commented 9 months ago

prawcore has been updated. Could you rebase and squash so the pipeline can run again?

github-actions[bot] commented 8 months ago

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

Watchful1 commented 8 months ago

Still planning on finishing this, just haven't had time recently.

github-actions[bot] commented 7 months ago

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

Watchful1 commented 7 months ago

Bump, will have time for this over the holidays if not before.

github-actions[bot] commented 6 months ago

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

Watchful1 commented 5 months ago

Bump

github-actions[bot] commented 4 months ago

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

LilSpazJoekp commented 1 month ago

Just checking in on this.

Watchful1 commented 1 month ago

It's still on my list, but pretty far at the bottom below other priorities. How much do you think it's actually needed? Reddit doesn't look like they are making any changes to the window size anytime soon.

LilSpazJoekp commented 1 month ago

Was waiting on doing a 8.0.0 release for this.

Would different paid tiers of rate limits make a difference in the rate limit calculation for optimal handling?

Watchful1 commented 1 month ago

Extremely unlikely they would have different window sizes. They just increase the requests per window. I imagine a lot of their infrastructure is built with the 10 minute window in mind.