search

praw-dev / praw

PRAW, an acronym for "Python Reddit API Wrapper", is a python package that allows for simple access to Reddit's API.
http://praw.readthedocs.io/
BSD 2-Clause "Simplified" License
3.47k stars 456 forks source link

Fix type checking imports #1993

Closed akd-io closed 10 months ago

akd-io commented 11 months ago

Fixes #1992

Feature Summary and Justification

This pull request updates type checking imports to praw.models where applicable to fix typing support for Pyright.

All instances found using grep -m 1 -E -- '->.*praw.models|import praw.models' praw/**/*.py as proposed on Discord: https://discord.com/channels/267624335836053506/1171494426359640064

References

akd-io commented 11 months ago

@LilSpazJoekp will you take a look at this? 😊

LilSpazJoekp commented 11 months ago

Yeah however, there seems to be an issue with the CI checks. I'll need to fix those before this can be merged.

akd-io commented 11 months ago

Yeah however, there seems to be an issue with the CI checks. I'll need to fix those before this can be merged.

Yea I see, no worries!

LilSpazJoekp commented 10 months ago

Thank you for fixing that!