search

prawnpdf / pdf-core

Implements low level PDF features for Prawn (experimental)
Other
23 stars 38 forks source link

Add support for Tz operator (horizontal scaling). #26

Closed msbit closed 7 years ago

msbit commented 8 years ago

Simple implementation of the Tz operator for allowing horizontal scaling of text.

pointlessone commented 8 years ago

Hello @msbit. Thank you very much for your contribution.

I'll take a closer look at the code a bit later. Meanwhile could you please add a spec or two that cover new code?

msbit commented 8 years ago

Hey @pointlessone. I've based the implementation on character_spacing, and so I was thinking of adding them into a PR for https://github.com/prawnpdf/prawn, as all the character_spacing specs seem to be in place on there. Would that be okay?

pointlessone commented 8 years ago

This is unfortunate consequence of extraction of PDF Core out of Prawn. There isn't always an obvious way to cut it.

Those specs definitely should belong here since the code is in this gem. Could you please file an issue about that since you've already inspected the code?

As for this PR we'd prefer specs here for this code and in Prawn gem for the code that uses this feature if any.

msbit commented 8 years ago

Okay, that sounds fair.

I'll look at the specs for this PR tomorrow, and while I'm investigating that I'll see if I can put together a reasonable overview of what would need to come across in terms of specs from prawn into pdf-core for character_spacing.

pointlessone commented 8 years ago

@msbit Thank you. Much appreciated.

msbit commented 8 years ago

Added specs covering the pdf-core specific parts of this.

msbit commented 7 years ago

👌