search

prawnpdf / prawn-table

Provides support for tables in Prawn
Other
205 stars 99 forks source link

Don't depend on Prawn to provide prawn.png #90

Closed tilsammans closed 7 years ago

tilsammans commented 7 years ago

This seems very brittle and unnessesary. Especially for the specs; it doesn't matter what image is used here, just that any image is used. For the manual, it could be argued that we get it from Prawn. But I think it makes our code too brittle for too little gain. Better to have evrything self-contained.

Fixes all Travis errors.

pointlessone commented 7 years ago

prawn-table has a hard dependency on Prawn. You simply can not use this gem without Prawn. It's OK to use an image from Prawn.

tilsammans commented 7 years ago

Okay, you seem to know what you're doing.

mikevm commented 5 years ago

I tried to 

bundle install && bundle exec rake spec

and got a complaint about this file prawn.png missing. I found it in the prawn-1.0.0 gem but not in the prawn-2.2.2 gem. Is it possible that prawn used to provide this image and now it doesn't, or am I misreading here?