search

prawnpdf / prawn

Fast, Nimble PDF Writer for Ruby
https://prawnpdf.org
Other
4.67k stars 688 forks source link

Fix missing glyph widths #1327

Closed pointlessone closed 9 months ago

pointlessone commented 9 months ago

This is an attempt to address an issue raised in https://github.com/prawnpdf/prawn/pull/1322#issuecomment-1895462228

mojavelinux commented 9 months ago

This fixes the original issue that I raised in https://github.com/prawnpdf/prawn/pull/1322#issuecomment-1895462228. However, I'm detecting one other failure in the Asciidoctor PDF test suite that is coming from changes in Prawn. I don't yet understand the failure. I'll report back once I do.

mojavelinux commented 9 months ago

Ha! The test is failing because Prawn is fixed. It was previously truncating Unicode characters outside of the 4-digit range (e.g., U+0f089a would become U+f089). Now the code does what it's supposed to do (preserves the original char code) and I just need to update the assumption in the test. False alarm.

With that out of the way, I can confirm that this fix addressed the compatibility issues.

pointlessone commented 9 months ago

Good to hear. Thank you. I will land this soon.