search

prawnpdf / ttfunk

Font Metrics Parser for Prawn
http://prawnpdf.org
Other
125 stars 75 forks source link

@offset not initialized warning when running 1.5.1 from RubyGems #61

Closed apjanke closed 2 years ago

apjanke commented 6 years ago

Hi, PrawnPDF folks,

When using ttfunk 1.5.1 in AsciidoctorJ, I'm getting some "@offset not initialized" warnings.


$ /usr/local/Cellar/asciidoctorj/1.5.7/bin/asciidoctorj -b pdf test.adoc
uri:classloader:/gems/prawn-svg-0.27.1/lib/prawn/svg/color.rb:212: warning: shadowing outer local variable - result
uri:classloader:/gems/prawn-svg-0.27.1/lib/prawn/svg/properties.rb:50: warning: `*' interpreted as argument prefix
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized

It looks like this was fixed in https://github.com/prawnpdf/ttfunk/commit/086b3126b13d207abf992279bef9b7699af8ae32. But that was after the latest 1.5.1 release. Maybe you could cut a new release so the fix can propagate to users running ttfunk through RubyGems?

ioquatix commented 4 years ago

@pointlessone can you please make a new release? Thanks.

petergoldstein commented 2 years ago

@pointlessone It looks like this can be closed.