search

prawnsalad / KiwiIRC

This is **DEPRECATED**! Please go to https://github.com/kiwiirc/kiwiirc
https://kiwiirc.com
GNU Affero General Public License v3.0
891 stars 277 forks source link

Minor fixes to the textstyle plugin #867

Open Robby- opened 8 years ago

driftypuddle commented 7 years ago

textstyle space you need that space because if you set color or bold or such and do a emote without take or space the emote does not show

Robby- commented 7 years ago

Oh, this still isn't merged yet? I forgot about this one, we've been using this ourselves since I submitted this here.

And, yes, I can see that emote thing is indeed a problem, but I do not think leaving the space there is the correct solution just to accommodate the emotes. The space really is unnecessary, and makes text appear ugly on IRC as well (everything was prefixed with a space). So in regards to this plugin, removing the space really is the correct fix here.

The emote not appearing because of that should best be fixed another way (though, I don't know how).

driftypuddle commented 7 years ago

yes I agree I can't remove the space at the mo too many users moaning not sure my self on how to fix the emote as well