prax-wallet / web

https://praxwallet.com
Apache License 2.0
3 stars 2 forks source link

Transaction confirmations are automatically canceled for plans with a lot of actions #130

Closed Valentine1898 closed 1 week ago

Valentine1898 commented 1 month ago

Describe the bug Transactions are automatically canceled when trying to create a dutch auction spread over 48 auctions In some cases this is not reproduced, but more often it is reproduced

To Reproduce Steps to reproduce the behavior:

  1. Go to Swap
  2. Create dutch auction for 24 or 48 hours
  3. You'll get a approval dialog and transaction cancellation after a couple of seconds

Expected behavior Prax should be able to create transactions with any number of actions

Screenshots

https://github.com/user-attachments/assets/2d08dc5f-2a94-4389-a3bc-d02b8479f587

grod220 commented 1 month ago

I can't seem to reproduce this. Do you see any errors in the console for minifront or prax?

Valentine1898 commented 1 month ago

I can't seem to reproduce this. Do you see any errors in the console for minifront or prax?

Yes, I'm getting these errors in prax

image

Edited: but I get the same errors if I manually cancel the transaction, so I don't think these are useful errors

TalDerei commented 1 month ago

cc @jessepinho

Valentine1898 commented 1 month ago

@grod220 I've concluded that the issue here https://github.com/prax-wallet/web/blob/8141aa42264e9873bbb6f2c625bf12145bc10da6/apps/extension/src/popup.ts#L23 Increasing the timeout solves the issue, but we probably want to have a more flexible solution

grod220 commented 1 month ago

Good find. This relates to this issue: https://github.com/penumbra-zone/web/issues/285. We should have a think about good designs for this.

grod220 commented 1 week ago

Fixed by https://github.com/prax-wallet/web/pull/174