search

praxes / hexrd

Legacy hexrd repository (python2.7)
http://hexrd.readthedocs.org
14 stars 42 forks source link

added package data to setup; removed obsolete cfg file #15

Closed donald-e-boyce closed 11 years ago

donald-e-boyce commented 11 years ago

I left the all_materials.cfg file in the data directory as a database, but that is not necessary to the distribution. Maybe we should drop that too.

ddale commented 11 years ago

Looks good to me.

ddale commented 11 years ago

Don, in case you are interested, you can do the following on this branch:

$ git commit --amend

Then change the commit message to something like:

adds package data to setup.py. fixes #9. fixes #10.

That way, when the branch gets merged to praxes/hexrd, the issues will automatically be closed.

I think this branch is ready to merge, with or without that change.

ddale commented 11 years ago

Actually, that operation may be problematic since you have already pushed the commit here. I think --amend will alter the history, and github will complain if you try to push it.

donald-e-boyce commented 11 years ago

I'll remember that in the future, though. So I put in "fixes #n." and it will close that?

Don

On Thu, Feb 7, 2013 at 4:54 PM, Darren Dale notifications@github.comwrote:

Actually, that operation may be problematic since you have already pushed the commit here. I think --amend will alter the history, and github will if you try to push it.

— Reply to this email directly or view it on GitHubhttps://github.com/praxes/hexrd/pull/15#issuecomment-13262212.

ddale commented 11 years ago

Yes. I can't find it documented at https://help.github.com/ , but it is mentioned at https://github.com/blog/831-issues-2-0-the-next-generation .