search

praxisdigital / mod_diplomasafe

Plugin made for interaction with Diplomasafe.com
Other
0 stars 0 forks source link

Does not support postgres #11

Open danmarsden opened 2 years ago

danmarsden commented 2 years ago

Please note that both mysql and postgres must be supported for acceptance in the plugins db - I see mysql specific functions related to timestamp handling, and hard-coded "CONCAT" style calls that should be using the moodle $DB->sql_concat API's

danmarsden commented 2 years ago

Please ensure that you test your plugin end to end in both mysql and postgres - I note you have a number of unit tests - if you configure the github actions here like mentioned in #5 you can get these to run on both postgres and mysql here in github which might also show up some of the issues.