praxisdigital / moodle-block_sharing_cart

plug-in for Moodle LMS
0 stars 3 forks source link

Mitnielsbrock - Error in sharingCart No userdata is copied. #71

Closed neeesn closed 1 year ago

neeesn commented 1 year ago

The error reported is: If you copy some activities with Sharingcart, the userdata is not included. Try copy a journal with sharingcart and in the popup marks that you want to copy usersdata, it doesnt. When the journal is inserted, again, its without userdata.

Small video that shows the problem: https://www.loom.com/share/aaaaf62314ed4b4aa0889a9fa8437c0c

neeesn commented 1 year ago

Tested in https://mitnielsbrock-dk-morris.moodle.praxis.dk/course/view.php?id=52887

frederikmillingpytlick commented 1 year ago

This issue occurs, because the sharing cart by default anonymizes the userdata in its backups if you have the "moodle/backup:anonymise" capability in the course module context.

frederikmillingpytlick commented 1 year ago

Ready for testing

fmp_GH-71_40 fmp_GH-71_311 fmp_GH-71_310

superfoght commented 1 year ago

hi @frederikmillingpytlick I can see you have made a fix for 4.0 but Niels Brock is still running 3.10

frederikmillingpytlick commented 1 year ago

@superfoght Sorry i missed that, I've backported to 3.11 and 3.11

Ready for testing

fmp_GH-71_40 fmp_GH-71_311 fmp_GH-71_310

neeesn commented 1 year ago

I have testet and it working. But i cant merge 3.11 and 4 branch beacause of conflict. image.png

Can you please solve it

frederikmillingpytlick commented 1 year ago

I've solved and merged the commits into both our fork and the sharing cart repo

frederikmillingpytlick commented 1 year ago

Ready for release @Mikkeljeppesen1