search

praxisdigital / moodle-block_sharing_cart

plug-in for Moodle LMS
0 stars 3 forks source link

Potentially relevant sharing_cart issues #79

Closed frederikmillingpytlick closed 1 year ago

frederikmillingpytlick commented 1 year ago

Potentially relevant issues:

mcardle commented 1 year ago

In an e-mail from Don he explains he preferably want us to look at issue #155

Hi Ulrik,

Thank you very much for dealing with this urgent request. I appreciate that you were able to incorporate the fixed code.

I agree to close the issue, and hope you will have time to look at issue #155 which concerns the question bank. There have been so many changes in the question bank, that I expect issues related to it. https://github.com/donhinkelman/moodle-block_sharing_cart/issues/155

Snowdle commented 1 year ago

Issue #155 has been addressed

AraPraxis commented 1 year ago

Following issues have been closed, since they're errors prior to Moodle 4.0, which we no longer update - However we are still willing to fix security risks (if any occur), as we follow the Moodle Releases https://moodledev.io/general/releases https://github.com/donhinkelman/moodle-block_sharing_cart/issues/21 https://github.com/donhinkelman/moodle-block_sharing_cart/issues/62 https://github.com/donhinkelman/moodle-block_sharing_cart/issues/68 https://github.com/donhinkelman/moodle-block_sharing_cart/issues/73 https://github.com/donhinkelman/moodle-block_sharing_cart/issues/78 https://github.com/donhinkelman/moodle-block_sharing_cart/issues/92

One have been escalated and is awaited further instructions -- As it's a wish from the customer it will be put in the backlog: https://github.com/donhinkelman/moodle-block_sharing_cart/issues/120

The rests should be looked at

AraPraxis commented 1 year ago

https://github.com/donhinkelman/moodle-block_sharing_cart/issues/143

The issue above is a request that we add tags to our updates to the plugin.

We've agreed on doing so, and I've added tags going back to 4.0 Release 2 & Release 5 The two releases have been chosen, as it's Donhinkelman that has updated the README.md to the correct release number, and 3 & 4 have a lot of merges, updates and pulls left and right, that I rather not get too involved with adding tags to wrong pushes.

AraPraxis commented 1 year ago

Issue https://github.com/donhinkelman/moodle-block_sharing_cart/issues/145 is tested and the Sharing Cart works fine with the given theme

AraPraxis commented 1 year ago

Issue https://github.com/donhinkelman/moodle-block_sharing_cart/issues/67 is sent to our customer team for testing

AraPraxis commented 1 year ago

Issue 67 is tested and sent to our release team - A PR has also been requested to donhinkelman

AraPraxis commented 1 year ago

Issue https://github.com/donhinkelman/moodle-block_sharing_cart/issues/86 has been researched and a Moodle Tracker issue has been created as Moodle would need to update their way of adding block instances - Further info can be read on the issue

AraPraxis commented 1 year ago

I've added 6 new issues (153, 154, 155, 157, 160, 162) and at the moment we're awaiting answers from the users after questions by donhinkelman or the undersigned

AraPraxis commented 1 year ago

We've closed all issues because of fixes, missing responses or denied requests..

Only issue 157 is awaiting donhinkelman about multi language error, but we'll look at it at a further time. Closing issue.